On Tue, 11 May 2021 19:08:46 GMT, Daniel D. Daugherty <dcu...@openjdk.org>
wrote:
> Thumbs up on the over all logic. I only have minor nits and suggestions.
Thank you!
> src/hotspot/share/prims/jvmtiRawMonitor.hpp line 48:
>
>> 46: // The rules are:
>> 47: // - We must never safepoint poll if raw monitor is owned.
>> 48: // - We may safepoint poll before it is owned and after it have been
>> released.
>
> nit typo: s/have been/has been/
Fixed
> src/hotspot/share/runtime/interfaceSupport.inline.hpp line 230:
>
>> 228: };
>> 229:
>> 230: template <typename PRE_PROC>
>
> When you mentioned doing this with templates, I was having
> nightmares, but this one is not bad at all...
:)
> src/hotspot/share/runtime/objectMonitor.cpp line 313:
>
>> 311: if (current->is_suspended()) {
>> 312: _om->_recursions = 0;
>> 313: _om->_succ = NULL;
>
> Please add a comment after this line:
> // Don't need a full fence after clearing successor here because of the call
> to exit().
Fixed
-------------
PR: https://git.openjdk.java.net/jdk/pull/3875
