Hi Sergey, It looks good to me too (if you need one more review).
Thanks, Serguei On 5/20/21, 6:36 AM, "jdk8u-dev on behalf of David Holmes" <[email protected] on behalf of [email protected]> wrote: On 20/05/2021 8:27 pm, Sergey Nazarkin wrote: > Thanks David, I’ve tagged the bug > > The test is not new, I tracked it down to jdk7. But EmbeddedVM build is quite tricky and it seems nobody care about it nowadays. Looks like the test got a major overhaul after JDK 8 was released. That may be when it stopped working with SE Embedded. Or it may be we used to run the tests such that -XX:+UsePerfData was passed by jtreg ... I don't recall now. :) Cheers, David > > /Sergey > >> On May 20, 2021, at 03:50, David Holmes <[email protected]> wrote: >> >> Hi Sergey, >> >> Fix looks fine. I'm a little surprised we have any SE Embedded test issues arising - is this a new test? >> >> Cheers, >> David >> >> >> On 20/05/2021 6:28 am, Sergey Nazarkin wrote: >>> Correct serviceability list address >>>> On May 19, 2021, at 22:19, Sergey Nazarkin <[email protected]> wrote: >>>> >>>> Hi! >>>> >>>> Please review small patch for the test that fails [1] on jdk8 built with JAVASE_EMBEDDED option. >>>> >>>> Embedded VM build disables [2] jvmstat instrumentation that prevent launched instance be detected by test agent. The fix [3] enables instrumentation for launched VM swarm and agent is able to detect them. >>>> >>>> The bug affects jdk8 only [4]. >>>> >>>> [1] https://bugs.openjdk.java.net/browse/JDK-8267426 >>>> [2] https://hg.openjdk.java.net/jdk8u/jdk8u-dev/hotspot/file/8c40ddd927ce/src/share/vm/runtime/globals.hpp#l3782 >>>> [3] http://cr.openjdk.java.net/~snazarki/jdk8u-dev-webrev/8267426/ >>>> [4] https://hg.openjdk.java.net/jdk-updates/jdk11u/file/bce3c3659531/src/hotspot/share/runtime/globals.hpp#l2413 >>>> >>>> >>>> >>>> >
