On Wed, 26 May 2021 02:18:06 GMT, David Holmes <[email protected]> wrote:
> Hi Stefan, > > I think this policy makes a lot of sense! > > I only scanned through the changes to get a sense of them but it all seemed > fine. > > Thanks, > David Thanks a lot for reviewing! > doc/hotspot-style.html line 97: > >> 95: <li><p>Do not put non-trivial function implementations in .hpp files. If >> the implementation depends on other .hpp files, put it in a .cpp or a >> .inline.hpp file.</p></li> >> 96: <li><p>.inline.hpp files should only be included in .cpp or .inline.hpp >> files.</p></li> >> 97: <li><p>All .inline.hpp files should include their corresponding .hpp >> file as the first include line. Externally used declarations should be put >> in the .hpp file, and not in the the .inline.hpp file. This rule exists to >> resolve problems with circular dependencies between.inline.hpp >> files.</p></li> > > typo: the the > Need space after between on last line Fixed. > doc/hotspot-style.md line 142: > >> 140: >> 141: * All .inline.hpp files should include their corresponding .hpp file >> 142: as the first include line. Externally used declarations should be put > > Do we need to spell out it should be first unless precompiled.hpp is included? We should never include precompiled.hpp from an .inline.hpp file, so I don't think we need to state that. ------------- PR: https://git.openjdk.java.net/jdk/pull/4127
