On Mon, 2021-05-03 at 17:57 -0700, Laurence Cable wrote: > > On 5/3/21 4:50 PM, David Holmes wrote: > > On 4/05/2021 9:07 am, Argha C wrote: > > > Hello David, > > > It does look quite similar. > > > The crux is factoring in the sum of cpu time across all shares, > > > instead of a single cpu share. > > > My proposal for implementing the fix is slightly different from > > > the PR, but happy to trust your advice on taking this forward. > > > > I would suggest liaising with the contributors of > > > > https://github.com/openjdk/jdk/pull/3656 > > > > so see if all of the issues can be addressed together. > > +1!
David, Larry: https://github.com/openjdk/jdk/pull/3656 ... is ready for integration. Could we get a second review, please? It addresses wrong cpuLoad() calculation of cpu quota and cpu shares-based cpu limits in containers. Thoughts? Thanks, Severin
