On Thu, 27 May 2021 15:19:59 GMT, Stefan Karlsson <[email protected]> wrote:
>> Martin Doerr has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Add comments as suggested by Dan. > > I wonder if this should be changed to perform the read once by using > Atomic::load? That's the guidance we've given the last few years. Some > background for this: JDK-8234192. I agree with @stefank and @dholmes-ora . It is nature to happen the change in thread.hpp to fix this problem. > Seperately, I'm unclear why we allow this race to exist. I thought we took > snapshots when threads were known to be safe and stable. But that is a > separate issue. Now we have Thread-Local handshake. I think we should use it at here. ------------- PR: https://git.openjdk.java.net/jdk/pull/4224
