On Mon, 31 May 2021 06:41:29 GMT, Robbin Ehn <[email protected]> wrote:
>> A trivial fix to cleanup Threads_lock comments in JVM/TI function headers. >> >> Also remove errant text added by the jframeID XSL template code: >> >> >> // java_thread - unchecked >> // depth - pre-checked as non-negative >> >> >> The first line about `jthread` is output in error. >> Only the second line about `depth` should be included. >> >> This fix is tested with a Mach5 Tier1 job set. > > Marked as reviewed by rehn (Reviewer). @robehn, @dholmes-ora and @sspitsyn - Thanks for the reviews! > It is rather confusing though as I couldn't figure out why some functions > have the threadsList-handle as part of the code generated via the XML > file, and some have it in the jvmtiEnv part of the code - e.g. compare > SetThreadLocalStorage and GetThreadLocalStorage. That would be an historical question for Robert Field. :-) Definitely not something I want to deal with in this change. ------------- PR: https://git.openjdk.java.net/jdk/pull/4254
