On Wed, 2 Jun 2021 10:25:38 GMT, Vladimir Ivanov <[email protected]> wrote:
>> Part of the JEP-306 integration wasn't tested past tier 3 and missed some >> changes needed in the vmTestbase/nsk tests. The crux of the changes for >> JEP-306 are that the strictfp modifier has no affect any more (all fp math >> is strict) and is not observable as a modifier. At the VM level ACC_STRICT >> is no longer defined for classfiles version 61+ (ie JDK 17+). >> >> Affected tests: >> >> - vmTestbase/nsk/jvmti/GetMethodModifiers/methmod001/ >> >> This test has a part that expects to read the ACC_STRICT modifier for a >> strictfp method - so that part is just deleted. >> >> Other jvmti test files refer to ACC_STRICT (but don't test anything) and so >> those references are also deleted. >> >> - vmTestbase/nsk/jdi/VirtualMachine/redefineClasses/redefineclasses007.java >> - vmTestbase/nsk/jdi/VirtualMachine/redefineClasses/redefineclasses008.java >> >> These each have two subtests (07 and 08) that test changing the strictfp >> modifier on a method. These subtests are just deleted. >> >> Testing: >> - local testing of affected test areas >> - tiers 1-5 also submitted for good measure (but may take a while to run >> and should not delay getting these fixes in places so that the CI returns to >> normal - thanks). >> >> Thanks, >> David > > Looks good. Thanks @iwanowww ! ------------- PR: https://git.openjdk.java.net/jdk/pull/4302
