On Tue, 1 Jun 2021 20:52:40 GMT, Daniel D. Daugherty <[email protected]> wrote:
>> The Thread-SMR project added counter based tests for various APIs. >> See "JDK-8167108 inconsistent handling of SR_lock can lead to crashes". >> >> Time based tests are more appropriate for stress kits so I'm >> updating the counter based tests to be time based instead. >> >> Two of the updated tests have shaken out failures that are tracked by: >> >> JDK-8264605 >> vmTestbase/nsk/jvmti/SuspendThread/suspendthrd003/TestDescription.java >> failed with "agent_tools.cpp, 471: (foundThread = (jthread) >> jni_env->NewGlobalRef(foundThread)) != NULL" >> >> JDK-8266593 vmTestbase/nsk/jvmti/PopFrame/popframe011 fails with >> "assert(java_thread == _state->get_thread()) failed: Must be" >> >> These updated tests are tested via Mach5 Tier[134567]. >> They have also been test by my Stress Kit runs for jdk-17+2[0-5]. > > Daniel D. Daugherty has updated the pull request incrementally with one > additional commit since the last revision: > > Apply @plummercj code review fix from JDK-8265153 to this review also. test/hotspot/jtreg/vmTestbase/nsk/jvmti/SuspendThread/suspendthrd003/suspendthrd003.cpp line 102: > 100: /* > 101: * Using printf() instead of NSK_DISPLAY1() in this loop > 102: * in order to slow down the rate of SuspendThread() calls. I don't understand the reason for wanting to slow down the rate, nor your reason for removing it. ------------- PR: https://git.openjdk.java.net/jdk/pull/4237
