On Thu, 10 Jun 2021 10:26:46 GMT, Igor Ignatyev <[email protected]> wrote:
> Hi all,
>
> could you please review this small fix for
> `serviceability/logging/TestFullNames.java` test?
> from JBS:
>> serviceability/logging/TestFullNames.java test contains two test cases:
>> specifying filename w/ and w/o "file=" prefix. yet, the test doesn't remove
>> the file, hence its 2nd test case doesn't really test much.
>
> the patch simply calls `File::delete` inside the loop and verifies that the
> file doesn't exist at the beginning of each iteration.
>
> testing: `serviceability/logging/TestFullNames.java` on
> `{linux,windows,macosx}-x64`
>
> Thanks,
> -- Igor
This pull request has now been integrated.
Changeset: 74007890
Author: Igor Ignatyev <[email protected]>
URL:
https://git.openjdk.java.net/jdk/commit/74007890bb9a3fa3a65683a3f480e399f2b1a0b6
Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod
8268542: serviceability/logging/TestFullNames.java tests only 1st test case
Reviewed-by: sspitsyn
-------------
PR: https://git.openjdk.java.net/jdk/pull/4461
