Hi,

Please note that hotspot changes require two reviews before integrating (unless a trivial change).

David


On 22/06/2021 6:31 pm, Denghui Dong wrote:
On Wed, 16 Jun 2021 03:33:14 GMT, Denghui Dong <dd...@openjdk.org> wrote:

Hi,

Could I have a review of this change that merges three vm 
operations(VM_PrintThreads, VM_PrintJNI, VM_FindDeadlocks) in thread_dump and 
signal_thread_entry.

`jstack` is a very common command, even in the production environment.

In addition to reduce the cost of entering safepoint, I think this patch also 
could ensure the consistency of the results of VM_PrintThreads and 
VM_FindDeadlocks.

This pull request has now been integrated.

Changeset: 1f0ea7c3
Author:    Denghui Dong <dd...@openjdk.org>
Committer: Yi Yang <yy...@openjdk.org>
URL:       
https://git.openjdk.java.net/jdk/commit/1f0ea7c3d62221405de982ba484c0ee985fa9d7b
Stats:     51 lines in 8 files changed: 5 ins; 33 del; 13 mod

8268857: Merge VM_PrintJNI and VM_PrintThreads and remove the unused field 
'is_deadlock' of DeadlockCycle

Reviewed-by: dholmes

-------------

PR: https://git.openjdk.java.net/jdk/pull/4504

Reply via email to