On Tue, 22 Jun 2021 21:01:46 GMT, Alex Menkov <amen...@openjdk.org> wrote:
> Updated AllModulesCommandTest to use dynamic port launching debuggee.
> Parsing debuggee listening address functionality is required in several tests
> (and we have other tests which need to be fixed the same way), so moved the
> code to new class in jdk.test.lib
It looks good to me. Just one minor question inlined.
Thanks,
Serguei
test/jdk/com/sun/jdi/JdwpAllowTest.java line 83:
> 81: String s = app.getProcessStdout();
> 82: JDWP.ListenAddress addr = JDWP.parseListenAddress(s);
> 83: if (addr != null) {
What is going to happen in the case of addr == null?
-------------
Marked as reviewed by sspitsyn (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/4560
