On Wed, 14 Jul 2021 04:48:41 GMT, Lin Zang <lz...@openjdk.org> wrote:
>> 8269909: getStack method in hprof.parser.Reader should use try-with-resource > > Lin Zang has updated the pull request with a new target base due to a merge > or a rebase. The incremental webrev excludes the unrelated changes brought in > by the merge/rebase. The pull request contains five additional commits since > the last revision: > > - fix indentation issue > - Merge branch 'master' into try > - revise code to handle the closing of embeded streams > - Merge branch 'master' into try > - 8269909: getStack method in hprof.parser.Reader should use > try-with-resource Hi Lin, These local names with extra numbers look strange. You introduced these numbers in order to fix naming conflicts. You also can avoid these conflicts by refactoring the code. Some of these fragments can be refactored to become a separate methods. I do not want to push hard on you with this but it is just something to consider to simplify the code and avoid such naming problems. Thanks, Serguei ------------- PR: https://git.openjdk.java.net/jdk/pull/4717
