On Mon, 7 Jun 2021 08:01:54 GMT, Lin Zang <[email protected]> wrote:
>> 8262386: resourcehogs/serviceability/sa/TestHeapDumpForLargeArray.java timed
>> out
>
> Lin Zang has updated the pull request with a new target base due to a merge
> or a rebase. The incremental webrev excludes the unrelated changes brought in
> by the merge/rebase. The pull request contains 18 additional commits since
> the last revision:
>
> - Merge branch 'master' into sadump-fix
> - Merge branch 'master' into sadump-fix
> - Merge branch 'master' into s-fix
> - add comment for the timestamp value
> - Merge branch 'master' into s-fix
> - Fix typo and add comment
> - Merge branch 'master' into s-fix
> - fix typo in comments
> - Merge branch 'master' into s-fix
> - Merge branch 'master'
> - ... and 8 more:
> https://git.openjdk.java.net/jdk/compare/ae8d154f...a87793c3
Changes requested by sspitsyn (Reviewer).
src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/utilities/HeapHprofBinWriter.java
line 1367:
> 1365: @Override
> 1366: public synchronized void write(int b) throws IOException {
> 1367: if (segmentMode && !unbufferedMode) {
It is not clear why the condition` !unbufferedMode` is additionally checked
here and several places below. The `SegmentedOutputStream` constructor always
sets `false` to the`unbufferedMode` field at L1344. Is it possible that
`segmentMode` can be also unbuffered?
src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/utilities/HeapHprofBinWriter.java
line 1496:
> 1494: }
> 1495: // buffer must be empty now.
> 1496: assert (segmentMode && (segmentWritten == 0) &&
> (unbufferedMode == false)) : "Wrong Status";
This assert repeats checks in asserts at lines L1489 and L1490.
It is not clear why this duplication is needed.
-------------
PR: https://git.openjdk.java.net/jdk/pull/2803
