On Thu, 16 Sep 2021 16:11:44 GMT, Serguei Spitsyn <sspit...@openjdk.org> wrote:
>> Lin Zang has updated the pull request with a new target base due to a merge >> or a rebase. The pull request now contains ten commits: >> >> - Merge branch 'master' into hprof >> - code clean up and refinement >> - Merge branch 'master' into hprof >> - make calculateGlobalJNIHandlesDumpRecordSize abstract >> - code clean up and remove useless methods >> - Merge branch 'master' into hprof >> - fix write size issue >> - Merge branch 'master' into hprof >> - 8269685: Optimize HeapHprofBinWriter implementation > > Hi Lin, > Thank you for update! > I've added several comments with formatting nits. > Otherwise, it looks okay to me but I did not review everything deeply. > Thanks, > Serguei Dear Serguei @sspitsyn ， Very appericate for your review and comments, I just updated the PR based on your comments. Thanks! Lin ------------- PR: https://git.openjdk.java.net/jdk/pull/4666
