On Wed, 6 Oct 2021 21:53:30 GMT, Yumin Qi <mi...@openjdk.org> wrote:
>> Please review,
>> Refactor fundamental CDS FileMapHeader code for reliable reading of basic
>> info from shared archive.
>> With the change, it makes it possible to read an archive generated by
>> different version of hotspot. Also it is possible to automatically generate
>> a CDS archive If the archive supplied is not readable or fails to pass the
>> check.
>>
>> Tests: tier1-4
>> jtreg on sa.
>>
>> Thanks
>> Yumin
>
> Yumin Qi has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Add offset check for _generic_header in populate_header
I just have one minor comment. It's up to you if you want to change it.
test/hotspot/jtreg/runtime/cds/appcds/dynamicArchive/ArchiveConsistency.java
line 58:
> 56: static void runTwo(String base, String top,
> 57: String jarName, String mainClassName, int
> exitValue,
> 58: String ... checkMessages) throws Exception {
I don't think this method is necessary since the existing run2() method seems
to do the same thing.
The only advantage I see is the call site is less verbose than before.
-------------
Marked as reviewed by ccheung (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/5768
