On Thu, 7 Oct 2021 06:21:52 GMT, Kim Barrett <kbarr...@openjdk.org> wrote:

>> Leo Korinth has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Use a thread local buffer so that the compiler might reorder operator new.
>
> src/hotspot/share/memory/allocation.hpp line 414:
> 
>> 412:   // allocation is done in a recursive step. In that case an assert 
>> will trigger.
>> 413:   class RecentAllocations {
>> 414:     static const unsigned BufferSize = 5;
> 
> "5" seems like an odd choice.

What would you suggest? I could make it "2", but then a smaller code change (or 
compiler upgrade) would force us to change the size. Any size is quite 
arbitrary, I will update this number to your suggestion if you give me a 
suggestion.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5387

Reply via email to