On Wed, 20 Oct 2021 02:23:25 GMT, Serguei Spitsyn <sspit...@openjdk.org> wrote:

> Hi Ioi, It looks good to me except the line 105 commented by Chris. I wonder 
> how should this be tested to make sure there are no regressions. Do we really 
> care about pre 1.4.2 formats? If so, what is the way to test it? We have a 
> little lack of knowledge in this area. I guess, we need the performance team 
> to get involved into this review. Thanks, Serguei

I am not sure about 1.4.2 formats. I guess we don't really care, but we should 
probably remove it in a separate RFE. I am trying to keep this PR from having 
any functional changes, and will just remove dead code.

For testing, I am running tiers 1-4. Will that be enough?

I'll ping the performance team.

Thanks
- Ioi

-------------

PR: https://git.openjdk.java.net/jdk/pull/5923

Reply via email to