On Mon, 8 Nov 2021 19:10:23 GMT, Ralf Schmelter <[email protected]> wrote:
>> Richard Reingruber has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Improve comment as suggested by Chris.
>
> src/jdk.jdwp.agent/share/native/libjdwp/threadControl.c line 812:
>
>> 810: {
>> 811: jthread resumer = evinfo->thread;
>> 812: ThreadNode *node;
>
> You could move the declaration into the if() block below, since it is not
> needed elsewhere.
Done.
> src/jdk.jdwp.agent/share/native/libjdwp/threadControl.c line 2192:
>
>> 2190: * ordering handlerLock has to be acquired before threadLock.
>> 2191: */
>> 2192: debugMonitorExit(threadLock);
>
> You could move this to the if (resumer != NULL) block, since otherwise all
> the locking and unlocking is not needed anyways as far as I can see.
Done. Thanks for reviewing!
-------------
PR: https://git.openjdk.java.net/jdk/pull/5849
