On Sat, 22 Jan 2022 13:33:24 GMT, Thomas Stuefe <stu...@openjdk.org> wrote:

> JDK-8249944 moved AllStatic to its own header. We should use that one instead 
> of allocation.hpp where possible to reduce header dependencies.
> 
> This patch:
> - replaces includes of allocation.hpp with allstatic.hpp where appropiate
> - fixes up resulting errors since this changes uncovers missing dependencies. 
> Mainly, missing includes of debug.hpp, of globalDefinitions.hpp, and missing 
> outputStream definitions.
> 
> Changes are trivial but onerous. Done partly with a script, partly manually.
> 
> Test:
> - Checked the build with gtests on Linux x86, x64, minimal, zero, aarch64, 
> for both fastdebug and release. All builds of course without PCH.
> - GHAs

Hi Thomas,

Seems okay - hard to validate (and I expect allocation.hpp to be included 
somewhere in most cases anyway).

Some of the changes seem to have nothing to do with:

-#include "memory/allocation.hpp"
+#include "memory/allStatic.hpp"

? Are these caused by transitive include changes?

Thanks,
David

-------------

Marked as reviewed by dholmes (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/7188

Reply via email to