On Wed, 9 Feb 2022 16:20:49 GMT, Emanuel Peter <d...@openjdk.java.net> wrote:
>> Deprecated ExtendedDTraceProbes. >> Edited help messages and man pages accordingly, added the 3 flags to man >> pages. >> Added flag to VMDeprecatedOptions test. >> Replaced the flag with 3 flags in SDTProbesGNULinuxTest.java. >> >> Checked that tests are not affected. > > Emanuel Peter has updated the pull request incrementally with one additional > commit since the last revision: > > updated warning messages and added 3 flags to man-pages Hi Emanuel, A few minor nits below. Thanks, David src/hotspot/share/runtime/globals.hpp line 1868: > 1866: product(bool, ExtendedDTraceProbes, false, > \ > 1867: "(Deprecated) Enable performance-impacting dtrace probes. " > \ > 1868: "Use a combination of -XX:+DTraceMethodProbes, " > \ You missed changing 'a' to 'the' here. src/java.base/share/man/java.1 line 2977: > 2975: .RE > 2976: .TP > 2977: .B \f[CB]\-XX:+DTraceAllocProbes\f[R] The three newly documented flags should all be marked "Linux and macOS". It is somewhat of a poor design that the flags are available on all platforms but only have an effect on systems with DTrace or SystemTap support - which (for our main platforms) is Linux and macOS. src/java.base/share/man/java.1 line 4017: > 4015: .B \f[CB]\-XX:+ExtendedDTraceProbes\f[R] > 4016: \f[B]Linux and macOS:\f[R] Enables additional \f[CB]dtrace\f[R] tool > probes > 4017: that affect the performance. Existing grammatical nit: please delete 'the'. src/java.base/share/man/java.1 line 4020: > 4018: By default, this option is disabled and \f[CB]dtrace\f[R] performs only > 4019: standard probes. > 4020: Use the combination of these flags instead: -XX:+DTraceMethodProbes, > -XX:+DTraceAllocProbes, -XX:+DTraceMonitorProbes The flags should be in a code font (use `-XX:...` in the markdown source). ------------- PR: https://git.openjdk.java.net/jdk/pull/7110
