On Tue, 8 Mar 2022 18:37:45 GMT, Aleksey Shipilev <sh...@openjdk.org> wrote:

>> There are few bugs in SetBreakpoint when it reaches for metaspace 
>> allocation, notably 
>> [JDK-8214992](https://bugs.openjdk.java.net/browse/JDK-8214992) and 
>> [JDK-8264149](https://bugs.openjdk.java.net/browse/JDK-8264149). This adds 
>> the test that exercises the metaspace allocation paths.
>> 
>> Requires [JDK-8282172](https://bugs.openjdk.java.net/browse/JDK-8282172) to 
>> pass cleanly in fastdebug mode.
>> 
>> Additional testing:
>>  - [x] New test on Linux x86_64 fastdebug
>>  - [x] New test on Linux x86_64 release
>>  - [x] New test with 
>> [JDK-8264149](https://bugs.openjdk.java.net/browse/JDK-8264149) reverted 
>> fails on Linux x86_64 release
>
> Aleksey Shipilev has updated the pull request with a new target base due to a 
> merge or a rebase. The incremental webrev excludes the unrelated changes 
> brought in by the merge/rebase. The pull request contains seven additional 
> commits since the last revision:
> 
>  - Rewrite test to use runtime class generation
>  - Review comments
>  - Merge branch 'master' into JDK-8282170-jvmti-setbreakpoint-test
>  - Fix copyright
>  - Merge branch 'master' into JDK-8282170-jvmti-setbreakpoint-test
>  - Merge branch 'master' into JDK-8282170-jvmti-setbreakpoint-test
>  - Fix

Not a review yet but I'd suggest to convert .c to .cpp.
In long term we would like to get rid of the *.c files in the 
serviceability/jvmti test folder for consistency.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7554

Reply via email to