On Tue, 29 Mar 2022 04:58:32 GMT, David Holmes <[email protected]> wrote:
>> Ioi Lam has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> @dholmes-ora comments: simplify the changes
>
> src/hotspot/share/runtime/arguments.hpp line 113:
>
>> 111: bool writeable() const { return _writeable; }
>> 112:
>> 113: bool readable() const {
>
> Might be better/simpler to keep is_readable and change to is_writeable(), as
> that avoids changing other files.
There's also `internal()`, which would need to be changed to `is_internal()` as
well for consistency. I chose to change `is_readable()` to `readable()` so I
just needed to change one name.
-------------
PR: https://git.openjdk.java.net/jdk/pull/7981
