On Wed, 13 Apr 2022 15:29:00 GMT, Thomas Stuefe <stu...@openjdk.org> wrote:
> I dislike having different behavior between debug and release, I prefer to > test what later runs in the field. Also, if we prevent crashes because we > want to ignore them, we should ignore them in debug too, otherwise, we burn > error analysis cycles needlessly. I copied this from JFR (where this the default, albeit configurable behaviour). But I agree and changed it. > What @tstuefe said about debug vs. production made me wonder whether the > assert in ThreadCrashProtection is still useful at all. I mean, we are > deliberately using it from threads other than the JFR sampler thread and if > that usage is not breaking stuff left and right, probably we could remove it? I agree, I'm going to remove it. Its functionality is too good to be restrained to JFR. ------------- PR: https://git.openjdk.java.net/jdk/pull/8225
