On Fri, 15 Apr 2022 07:40:04 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:
> I ran `codespell` on hotspot, and accepted those changes where it indeed > discovered real typos. > > You'd be surprised over the many implementions of instrinsics and other > intructions accross all archtectures I've encounted, so for the preceding > reason it's neccesery to sucessfully seach for exisiting typos... I tried to cover all serviceability files, but didn't want to pick and choose individual files within any given directory, so I reviewed all files in any directory that contained a serviceability related file. So the following were covered by my review: src/os src/os_cpu src/share/prims src/share/services src/hotspot/share/prims/jvmtiThreadState.hpp line 136: > 134: ~JvmtiThreadState(); > 135: > 136: // is event_type enabled and usable for this thread in any > environments? Should it be "environment"? src/hotspot/share/services/memTracker.hpp line 128: > 126: > 127: // Record arena size change. Arena size is the size of all arena > 128: // chunks that backing up the arena. This doesn't read correctly (not due to your change). Perhaps "that back up" or "that are backing up" is what was intended. ------------- Marked as reviewed by cjplummer (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/8260
