On Tue, 3 May 2022 08:02:57 GMT, Johannes Bechberger <d...@openjdk.java.net> 
wrote:

>> Calling JavaThread::thread_from_jni_environment for a terminated thread in 
>> AsyncGetCallTrace might cause the acquisition of a lock, making 
>> AsyncGetCallTrace non-signal-safe. 
>> 
>> AsyncGetCallTrace can only be called for the current threads (there are 
>> asserts for that), therefore using JavaThread::current directly and checking 
>> the termination status is semantically equivalent.
>
> Johannes Bechberger has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   Merge cast into condition

Looks good.

Thanks.

-------------

Marked as reviewed by dholmes (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/8446

Reply via email to