On Tue, 3 May 2022 23:20:28 GMT, Alex Menkov <amen...@openjdk.org> wrote:
>> The test counts all "system" threads before the execution and expects that >> this number remains the same during test execution. >> This makes the test fragile - JVM may start internal threads, some threads >> may end. >> >> The fix updates the test: >> - the test checks only test threads, and verify that the live threads are >> reported by GetAllThreads and terminated threads are not reported; >> - dropped "system" thread counting stuff; >> - added proper deallocation of GetThreadInfo results. > > Alex Menkov has updated the pull request incrementally with one additional > commit since the last revision: > > feedback test/hotspot/jtreg/vmTestbase/nsk/jvmti/GetAllThreads/allthr001/allthr001.cpp line 184: > 182: jthread *threads; > 183: int i, j; > 184: bool found; Nit: this isn't old style C code, we don't have to declare all variables up front. New variables should be declared where needed. ------------- PR: https://git.openjdk.java.net/jdk/pull/8512
