On Thu, 12 May 2022 06:43:29 GMT, KIRIYAMA Takuya <d...@openjdk.java.net> wrote:
> ClassTransformer.java is duplicated because ClassTransformer.java was copied > from test/jdk/com/sun/jdi/lib/jdb to test/lib/jdk/test/lib/util at > [JDK-8240908](https://bugs.openjdk.java.net/browse/JDK-8240908). > test/lib/jdk/test/lib/util/ClassTransformer.java should be deleted and > test/jdk/com/sun/jdi/lib/jdb/ClassTransformer.java should be used. This is > because ClassTransformer is used for testing jdi, and it is not appropriate > to exist in test/lib/jdk/test/lib/util. > Would you please review this fix? There are 2 point here. 1. You started to work on a fix for issue assigned to another engineer. This is a way to duplicate effort and waste time. I have a fix ready locally, but haven't submitted a PR (had to resolve dependency first). 2. Looks like you misunderstood the issue. There are tests which use ClassTransformer outside of test/jdk/com/sun/jdi (and there are test which use ClassTransformer in other project, and that was the reason the file was copied by JDK-8240908). Actually your fix changes test from lang/instrument, so the fix conflicts with the PR description. So I think it's better to withdraw the PR - I'll create another one soon. ------------- PR: https://git.openjdk.java.net/jdk/pull/8672
