On Tue, 17 May 2022 13:49:25 GMT, Jaroslav Bachorik <jbacho...@openjdk.org> 
wrote:

>> src/hotspot/share/prims/forte.cpp line 594:
>> 
>>> 592:   }
>>> 593: 
>>> 594:   // !important! make sure all return points will reset the IN_ASGCT 
>>> flag to 'false'
>> 
>> Please change it to something like "// !important! make sure all to call 
>> set_in_asgct(false) before every return" as this is clearer in the context 
>> of the forte.cpp and omits mentioning the encapsulated state.
>
> 👌 
> I have modified the comment wording

There is an "all" to much in the new version, I forgot to remove it in my 
suggestion

-------------

PR: https://git.openjdk.java.net/jdk/pull/8549

Reply via email to