On Thu, 25 Aug 2022 22:04:47 GMT, Coleen Phillimore <[email protected]> wrote:
>> Axel Boldt-Christmas has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add context active assert
>
> src/hotspot/share/prims/jvmtiRedefineClasses.cpp line 4157:
>
>> 4155: }
>> 4156: }
>> 4157: log_debug(redefine, class, nmethod)("Enqueued all nmethods for
>> deopt");
>
> This seems to do the opposite of encapsulating nmethod logic by exposing
> RedefineClasses to the interesting bits of CodeCache iteration. And details
> of deoptimization that redefine classes really has other things to worry
> about. I didn't realize you were doing this. I suppose it's better than a
> big #if JVMTI in codeCache.cpp.
Maybe this is ok, but I want to look at it more. The reason these functions
started out in codeCache is because they looked like other functions in
codeCache.
-------------
PR: https://git.openjdk.org/jdk/pull/9655
