On Thu, 9 Mar 2023 09:29:41 GMT, Markus Grönlund <[email protected]> wrote:
>> src/hotspot/share/runtime/threads.cpp line 338:
>>
>>> 336: if (EagerXrunInit && Arguments::init_libraries_at_startup()) {
>>> 337: create_vm_init_libraries();
>>> 338: }
>>
>> Not obvious where this went. Changes to the initialization order can be very
>> problematic.
>
> Thanks, David. Two calls to launch XRun agents are invoked during startup,
> and they depend on the EagerXrunInit option. The !EagerXrunInit case is
> already located in create_vm(), but the EagerXrunInit was located as the
> first entry in initialize_java_lang_classes(), which I thought was tucked
> away a bit unnecessarily.
>
> I hoisted the EagerXrunInit case from initialize_java_lang_classes() up to
> create_vm(). It's now the call just before initialize_java_lang_classes().
>
> This made it clearer, i.e. to have both calls located directly in create_vm().
Thanks for clarifying. That makes sense.
-------------
PR: https://git.openjdk.org/jdk/pull/12923
