On Wed, 26 Apr 2023 16:07:33 GMT, Daniel D. Daugherty <[email protected]>
wrote:
>> Roman Kennke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove unnecessary comments
>
> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/runtime/Threads.java line
> 231:
>
>> 229:
>> 230: public JavaThread owningThreadFromMonitor(ObjectMonitor monitor) {
>> 231: if (VM.getVM().getCommandLineFlag("LockingMode").getInt() == 2)
>> {
>
> Please put a comment after that literal '2':
>
> if (VM.getVM().getCommandLineFlag("LockingMode").getInt() == 2 /*
> LM_LIGHTWEIGHT */) {
You could add the LM_LEGACY, LM_LIGHTWEIGHT literals to vmStructs.cpp and
compare with them.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/10907#discussion_r1181662882
