On Sat, 29 Apr 2023 15:54:23 GMT, Afshin Zafari <d...@openjdk.org> wrote:
>> The `finalize()` method is removed from base classes/interfaces and are
>> replaced by a Cleaner callback..
>
> Afshin Zafari has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 8305083: Remove finalize() from test/hotspot/jtreg/vmTestbase/nsk/share/
> and /jpda that are used in serviceability/dcmd/framework tests
Not sure about keeping the "finalize" terminology - though perhaps with more
extensive commenting in the key classes it may be okay.
test/hotspot/jtreg/vmTestbase/nsk/share/Finalizable.java line 48:
> 46: * It is implemented in FinalizableObject.
> 47: */
> 48: public void registerCleanup();
Can you not implement this as a default method?
test/hotspot/jtreg/vmTestbase/nsk/share/FinalizableObject.java line 39:
> 37:
> 38: /**
> 39: * This method will be invoked by <tt>Finalizer</tt> when virtual
> mashine
You copied the `mashine` typo here.
test/hotspot/jtreg/vmTestbase/nsk/share/FinalizableObject.java line 49:
> 47: public void cleanup() {}
> 48: /**
> 49: * This method will be invoked by <tt>Finalizer</tt> when virtual
> mashine
Another `mashine` typo.
-------------
PR Review: https://git.openjdk.org/jdk/pull/13420#pullrequestreview-1408541140
PR Review Comment: https://git.openjdk.org/jdk/pull/13420#discussion_r1182188265
PR Review Comment: https://git.openjdk.org/jdk/pull/13420#discussion_r1182182712
PR Review Comment: https://git.openjdk.org/jdk/pull/13420#discussion_r1182183297
