On Sun, 5 May 2024 18:07:47 GMT, Leonid Mesnik <lmes...@openjdk.org> wrote:
>> The jdwp tests use debugger and debugee. There is no goal to execute >> debugger part with all VM flags, they are needed to be used with debugee VM >> only. >> The change is all tests is to don't use System.exit() and use 'driver' >> instead of othervm. >> test/hotspot/jtreg/vmTestbase/nsk/share/jpda/DebugeeBinder.java >> is updated to correctly set classpath for debugee > > Leonid Mesnik has updated the pull request incrementally with one additional > commit since the last revision: > > identation updated. There is something wrong with this diff. The original commit showed a lot of diffs to change main/othervm to driver (the main purpose of this PR), but now I don't see any of those changes and instead for the most part all I see is the very minor change to add a space in the `run()` call arguments. I think for some reason only your 2nd commit is being applied to this PR and the first commit was lost. However, the loss of the first commit is not showing up in the incremental diff of the two commits. I'm not sure what's going on. ------------- PR Comment: https://git.openjdk.org/jdk/pull/18826#issuecomment-2161262911
