On Tue, 13 Aug 2024 21:56:29 GMT, Daniel D. Daugherty <dcu...@openjdk.org>
wrote:
>> Axel Boldt-Christmas has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Whitespace and nits
>
> src/hotspot/share/runtime/vframe.cpp line 252:
>
>> 250: if (mark.has_monitor()) {
>> 251: ObjectMonitor* mon =
>> ObjectSynchronizer::read_monitor(current, monitor->owner(), mark);
>> 252: if (// if the monitor is null we must be in the process of
>> locking
>
> nit - please add a space after `(`
Should I align the rest of the lines? Adding the extra space here looks strange
to me. But the inlined comments looks strange as well. This is all pre-existing
code that just moved around a bit.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20067#discussion_r1716616351
