On Thu, 19 Sep 2024 04:27:54 GMT, David Holmes <dhol...@openjdk.org> wrote:
>> Simon Tooke has updated the pull request incrementally with one additional >> commit since the last revision: >> >> remove tabs > > test/hotspot/gtest/runtime/test_os.cpp line 453: > >> 451: errno = 0; >> 452: returnedBuffer = os::realpath(tmppath, buffer, sizeof(buffer)); >> 453: EXPECT_TRUE(errno == EINVAL); > > How is this an EINVAL case? You are correct - this was a cut and paste error; the call tested should have been `os::realpath(tmppath, nullptr, sizeof(buffer));` ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20683#discussion_r1766304627
