On Tue, 1 Oct 2024 16:16:36 GMT, Severin Gehwolf <sgehw...@openjdk.org> wrote:

> The change of [JDK-8327114](https://bugs.openjdk.org/browse/JDK-8327114) also 
> increased test coverage. In particular, the `TestJcmdWithSideCar.java` test 
> got enhanced to cover these cases (prior to 
> [JDK-8327114](https://bugs.openjdk.org/browse/JDK-8327114) only case 1 was 
> tested):
> 
> 1. Shared volumes between attachee and attacher and shared pid namespace
> 2. Shared volumes between attachee and attacher and shared pid namespace, 
> both running with elevated privileges
> 3. Shared pid namespace between attachee and attacher only
> 4. Shared pid namespace between attachee and attacher, both running with 
> elevated privileges
> 
> The OpenJDK attach code is able to handle cases 1 through 3 which pass, but 
> the last case, `4`, hasn't been implemented yet when running as regular user 
> and directing the container runtime to map the container user to that user as 
> well. Thus, the test fails. For now I propose to disable the 4th test case. 
> It can get re-enabled once the product code got updated to account for this 
> case (tracked in https://bugs.openjdk.org/browse/JDK-8341349).
> 
> Thoughts? Could somebody please run this through Oracle's test system in 
> order to see if this fixes the issue? Thank you!

This pull request has now been integrated.

Changeset: 21f8ccf4
Author:    Severin Gehwolf <sgehw...@openjdk.org>
URL:       
https://git.openjdk.org/jdk/commit/21f8ccf4a97313593f210f9a07e56d5ff92b7aa5
Stats:     9 lines in 1 file changed: 8 ins; 1 del; 0 mod

8341310: Test TestJcmdWithSideCar.java should skip ACCESS_TMP_VIA_PROC_ROOT 
(after JDK-8327114)

Reviewed-by: kevinw

-------------

PR: https://git.openjdk.org/jdk/pull/21289

Reply via email to