On Tue, 15 Oct 2024 22:31:46 GMT, Alex Menkov <amen...@openjdk.org> wrote:
>> The fix improves Attch API protocol and implements updated protocol on
>> windows; shared code is ready to implement updated protocol support on other
>> platforms.
>> More detailed explanations on the 1st comment.
>>
>> Testing: tier1,tier2,tier3,tier4,hs-tier5-svc
>> manually tested backward compatibility (old tools can attach to current
>> VMs, current tools can attach to older VMs) on Windows with jdk21u and jdk8u.
>
> Alex Menkov has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - updated comment
> - feedback
test/hotspot/jtreg/serviceability/attach/AttachAPIv2/CompatTest.java line 48:
> 46: public static void main(String[] args) throws Exception {
> 47: // if the test (client part) in the "compat" mode
> 48: boolean clientCompat =
> "true".equals(System.getProperty("jdk.attach.compat"));
Boolean.getBoolean("jdk.attach.compat") ignores case for us as well.
But more generally, are we happy with "jdk.attach.compat" as a boolean flag, or
would "jdk.attach.version" be better?
(which is mainly asking if we think there might ever be another version!)
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20782#discussion_r1810432507
