On Tue, 29 Oct 2024 07:59:54 GMT, Thomas Stuefe <stu...@openjdk.org> wrote:
>> Simon Tooke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> changes from review
>
> src/hotspot/os/bsd/memMapPrinter_macosx.cpp line 212:
>
>> 210: }
>> 211:
>> 212: st->print_cr("Number of mappings: %u", _num_mappings);
>
> If you reshuffle the lines (move this up), you can combine the conditions for
> err_vm ==/!= KERN_SUCCESS into one statement, would be easier to read
Done. My thinking was to separate the information gathering from the display
code.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20953#discussion_r1820621330
