On Tue, 29 Oct 2024 19:08:12 GMT, Larry Cable <d...@openjdk.org> wrote:
>> src/jdk.attach/linux/classes/sun/tools/attach/VirtualMachineImpl.java line
>> 114:
>>
>>> 112: String.format("Unable to open socket file %s:
>>> " +
>>> 113: "target process %d doesn't respond within
>>> %dms " +
>>> 114: "or HotSpot VM not loaded", socket_path,
>>> time_spend));
>>
>> Do we still need a pid argument after this format string?
>> time_spent would read more easily than "spend" 8-) but we had have that for
>> years.
>
> generally I dont think its a good idea to modify exception msgs ...
Agreed, this message is quite a famous "interface", it shouldn't change. I'm
saying it looks like the pid parameter disappears as you move time_spend to the
line above?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21688#discussion_r1822793215
