On Thu, 31 Oct 2024 20:12:06 GMT, Dean Long <dl...@openjdk.org> wrote:

>> Patricio Chilano Mateo has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   Fix typos in comments
>
> test/hotspot/gtest/nmt/test_vmatree.cpp line 34:
> 
>> 32: 
>> 33: using Tree = VMATree;
>> 34: using TNode = Tree::TreapNode;
> 
> Why is this needed?

We had to rename the alias to avoid a compiling with the Node in compile.hpp. 
Just lucky not to run into this in main-line. I think Johan had planned to 
change this in main line but it may have got forgotten.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21565#discussion_r1825121520

Reply via email to