On Thu, 7 Nov 2024 13:16:19 GMT, Coleen Phillimore <cole...@openjdk.org> wrote:
>> Ioi Lam has updated the pull request incrementally with one additional >> commit since the last revision: >> >> @DanHeidinga comment -- exit VM when runtimeSetup() fails > > src/hotspot/share/cds/aotConstantPoolResolver.cpp line 2: > >> 1: /* >> 2: * Copyright (c) 2022, 2024, Oracle and/or its affiliates. All rights >> reserved. > > If this is a new file, it shouldn't have 2022 in the copyright year. Oh looks like it's been moved from classPrelinker, except git doesn't show it's moved. If it's added as a moved file, would there be less diffs to look at? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21642#discussion_r1832685160
