On Thu, 21 Nov 2024 18:12:43 GMT, William Kemper <wkem...@openjdk.org> wrote:
>> src/hotspot/share/gc/shenandoah/shenandoahHeap.hpp line 514:
>>
>>> 512:
>>> 513: public:
>>> 514: ShenandoahController* control_thread() { return _control_thread; }
>>
>> This method and field is probably `controller` then, right?
>
> Left the accessor and field with the same name to reduce churn. Clients of
> this method don't really need to change because in most (all?) cases, the
> public API of `ShenandoahControlThread` is declared in `ShenandoahController`.
OK.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21273#discussion_r1852731729
