On Fri, 22 Nov 2024 16:48:04 GMT, Severin Gehwolf <sgehw...@openjdk.org> wrote:

> The added code in `CgroupUtil::adjust_controller` runs for cg v1 and cg v2 
> when path adjustment is deemed needed. So I'm not clear why it's needed for 
> cg v2

It looks like there's no way to see at this point, if we are in cgroup v1 or v2 
- if I am not mistaken.

> I thought we have established that for cg v2 && `--cgroupns=host` the current 
> path adjustment is sufficient? What am I missing?

The current path adjustment still needs correction of `lowest_limit` in cg v2. 
Also allocating `limit_cg_path` is important, that's why I added the if block.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21808#discussion_r1854921422

Reply via email to