On Tue, 4 Feb 2025 10:16:45 GMT, Johan Sjölen <jsjo...@openjdk.org> wrote:
>> The fix implements streaming output support for attach protocol. >> See JBS issue for evaluation, summary of the changes in the 1st comment. >> Testing: tier1..4,hs-tier5-svc > > src/hotspot/share/services/attachListener.cpp line 139: > >> 137: } >> 138: } else { >> 139: /* TODO: handle buffer overflow > > Important `TODO` :-). This is for [JDK-8319307](https://bugs.openjdk.org/browse/JDK-8319307) @tstuefe Do you want to keep this comment to work on JDK-8319307? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/23405#discussion_r1941840271