On Fri, 21 Feb 2025 06:36:14 GMT, Serguei Spitsyn <sspit...@openjdk.org> wrote:

>> Kevin Walls has updated the pull request with a new target base due to a 
>> merge or a rebase. The incremental webrev excludes the unrelated changes 
>> brought in by the merge/rebase. The pull request contains eight additional 
>> commits since the last revision:
>> 
>>  - comments
>>  - Merge remote-tracking branch 'upstream/master' into 
>> 8347433_DescriptorSupport_deprecate_XML
>>  - (c)
>>  - typo
>>  - Merge remote-tracking branch 'upstream/master' into 
>> 8347433_DescriptorSupport_deprecate_XML
>>  - Also XMLParseException
>>  - RMMB comment update
>>  - Deprecate XML interchange in DescriptorSupport
>
> src/java.management/share/classes/javax/management/modelmbean/DescriptorSupport.java
>  line 1170:
> 
>> 1168:                 " with arg: <" + s + ">";
>> 1169:             throw new XMLParseException(e, msg);
>> 1170:             // XMLParseException is deprecated for removal.
> 
> Q: Non-deprecated method will be using the deprecated class 
> `XMLParseException`. What is the plan for replacement? Should this be fixed 
> now? The same question for the line 1160.

Aside from the public deprecated API, the only places where this exception is 
used is in private static methods that support the implementation of the 
deprecated constructor, so these will go away when the constructor is 
eventually removed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23038#discussion_r1965157527

Reply via email to