On Sat, 26 Apr 2025 11:31:39 GMT, Albert Mingkun Yang <[email protected]> wrote:
>> Casper Norrbin has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> feedback fixes
>
> There are still a few matches for "hrt.ticks"; don't know if they should be
> removed (in this PR or a followup).
Thank you for reviewing @albertnetymk! I'll look into the last traces of
"hrt.ticks" to see if they can be removed here.
> src/hotspot/share/runtime/perfData.cpp line 455:
>
>> 453: assert(value != nullptr, "property name should be have a value: %s",
>> name);
>> 454: assert_system_property(name, value, CHECK);
>> 455: if (value != nullptr) {
>
> Why checking null again? Didn't we just asserted that 2 lines above?
This was from the original moved function, but I agree its redundant. Removed
it now.
> src/hotspot/share/runtime/threads.cpp line 852:
>
>> 850: #endif // INCLUDE_MANAGEMENT
>> 851:
>> 852: PerfDataManager::create_misc_perfdata();
>
> Should this be guarded by `UsePerfData`?
It should, thank you for spotting.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/24872#issuecomment-2838158557
PR Review Comment: https://git.openjdk.org/jdk/pull/24872#discussion_r2065957329
PR Review Comment: https://git.openjdk.org/jdk/pull/24872#discussion_r2065955553
