On Fri, 9 May 2025 22:34:45 GMT, Chen Liang <li...@openjdk.org> wrote:
>> For early eval; test by changing the ClassReader max accepted version of >> test ASM to 24 instead of 25 > > Chen Liang has updated the pull request with a new target base due to a merge > or a rebase. The incremental webrev excludes the unrelated changes brought in > by the merge/rebase. The pull request contains six additional commits since > the last revision: > > - Move other tier 4,5, etc tests to not use ClassReader > - Merge branch 'master' of https://github.com/openjdk/jdk into > fix/asm-test-upgrade > - Merge branch 'master' of https://github.com/openjdk/jdk into > fix/asm-test-upgrade > - Use classfile api instead of javac setting version > - Merge branch 'master' of https://github.com/openjdk/jdk into > fix/asm-test-upgrade > - 8356548: Avoid using ASM to parse latest class files in tests The runtime test that I know looks good. Ask @iwanowww and @sspitsyn about the compiler and redefinition tests. test/hotspot/jtreg/runtime/MirrorFrame/Asmator.java line 38: > 36: public void atStart(CodeBuilder builder) { > 37: // make receiver go dead! > 38: builder.aconst_null().astore(0); This looks much better. ------------- Marked as reviewed by coleenp (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/25124#pullrequestreview-2847613695 PR Review Comment: https://git.openjdk.org/jdk/pull/25124#discussion_r2093670551
