On Fri, 6 Jun 2025 15:44:28 GMT, Coleen Phillimore <cole...@openjdk.org> wrote:
>> Radim Vansa has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Add more comments >> - Disable search table with dynamic CDS > > src/hotspot/share/oops/fieldInfo.inline.hpp line 126: > >> 124: fi._offset = _r.next_uint(); >> 125: fi._access_flags = AccessFlags(checked_cast<u2>(_r.next_uint())); >> 126: fi._field_flags = FieldInfo::FieldFlags(_r.next_uint()); > > These callers don't need to know about _r even though they're in > FieldInfoStream. And then you don't need to make these changes. The addition of read_name_and_signature() is a good level of abstraction. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/24847#discussion_r2132437537
