On Tue, 23 Sep 2025 04:30:46 GMT, Serguei Spitsyn <[email protected]> wrote:
>> Johan Sjölen has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Merge remote-tracking branch 'origin/operands-again' into operands-again
>> - Fix BSM naming
>
> src/hotspot/share/oops/constantPool.hpp line 128:
>
>> 126:
>> 127: // The BSMAttributeEntries stores the state of the BootstrapMethods
>> attribute.
>> 128: class BSMAttributeEntries {
>
> Nit: I'm thinking if it would make sense to rename it to `BSMEntries`.
> Then we could rename this as well: `BSMAttributeEntry` => `BSMEntry`.
> It feels like it will increase the readability as it is already clear that
> `BSMEntry` is about `BSM` attributes.
Hmm, I don't want to go into renaming them in this PR. I think that's something
that can be done separately.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27198#discussion_r2378887133
