On Wed, 24 Sep 2025 02:09:02 GMT, Fei Yang <[email protected]> wrote:
>> Fredrik Bredberg has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update after review > > src/hotspot/cpu/riscv/c1_MacroAssembler_riscv.hpp line 71: > >> 69: // basic_lock: must be x10 & must point to the basic lock, contents >> destroyed >> 70: // temp : temporary register, must not be scratch register t0 or >> t1 >> 71: void unlock_object(Register swap, Register obj, Register lock, >> Register temp, Label& slow_case); > > You might want to rename the third param `lock` to `basic_lock`. > > > void unlock_object(Register swap, Register obj, Register basic_lock, Register > temp, Label& slow_case); Fixed ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/27448#discussion_r2375539612
